Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory destroy method #825

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Add factory destroy method #825

merged 8 commits into from
Oct 18, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

JS SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner September 20, 2024 16:43
@EmilianoSanchez EmilianoSanchez changed the base branch from development to SDKS-8407_baseline September 20, 2024 16:43
javrudsky
javrudsky approved these changes Sep 23, 2024
View reviewed changes
Copy link

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EmilianoSanchez EmilianoSanchez merged commit cba2a83 into SDKS-8407_baseline Oct 18, 2024
3 checks passed
@EmilianoSanchez EmilianoSanchez deleted the add_factory_destroy_method branch October 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @javrudsky